0d4875dec9
Two SSRF findings were OPEN with no in-flight fix; both are closed now using narrow defenses that key off existing trust boundaries. VERIA-6 (Milvus ``litellm_embedding_config``): ``is_request_body_safe`` already blocks ``api_base`` / ``api_key`` / ``langfuse_host`` / ``s3_endpoint_url`` / etc. at the *root* of the request body, gated by an admin opt-in (``allow_client_side_credentials`` or per-deployment ``configurable_clientside_auth_params``). The bug is that the Milvus vector-store transformer unpacks ``litellm_embedding_config`` into ``litellm.embedding(**embedding_config)``, so a caller can smuggle the same banned params in via nesting and bypass the check. Fix: ``is_request_body_safe`` now recurses into a known list of nested-config dicts (``litellm_embedding_config`` for now) and applies the same banned-param check with the same admin opt-in. Admin-side vector-store config flows through ``litellm_params`` rather than the request body, so it's unaffected. VERIA-51 (polling URLs returned by upstream APIs): Azure DALL-E 2, Azure Document Intelligence, and Black Forest Labs all blindly fetched a polling URL returned by the upstream and attached the operator's API key to the request. A compromised upstream or a future API contract change could redirect credentials anywhere. New ``url_utils.assert_same_origin(candidate, expected)`` helper checks scheme, host (case-insensitive), and port (with default-port normalization). Applied at all five polling sites: Azure DALL-E sync+async, Azure DI sync+async, BFL image generation sync+async, BFL image edit sync+async. Cross-origin polling URLs now raise rather than forward credentials. The Azure DALL-E ``Expected 'status' in response`` exception no longer reflects the raw response body — that path turned Blind SSRF into Full-Read SSRF for the limited window before the origin check fully closed it. Tests: 7 ``assert_same_origin`` unit tests, 6 ``is_request_body_safe`` nested-config tests, 5 polling-site rejection tests + 1 same-origin sanity check. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| agent_tests | ||
| audio_tests | ||
| basic_proxy_startup_tests | ||
| batches_tests | ||
| benchmarks | ||
| code_coverage_tests | ||
| documentation_tests | ||
| enterprise | ||
| guardrails_tests | ||
| image_gen_tests | ||
| litellm | ||
| litellm_core_utils | ||
| litellm_utils_tests | ||
| litellm-proxy-extras | ||
| llm_responses_api_testing | ||
| llm_translation | ||
| load_tests | ||
| local_testing | ||
| logging_callback_tests | ||
| mcp_tests | ||
| multi_instance_e2e_tests | ||
| ocr_tests | ||
| old_proxy_tests/tests | ||
| openai_endpoints_tests | ||
| otel_tests | ||
| pass_through_tests | ||
| pass_through_unit_tests | ||
| proxy_admin_ui_tests | ||
| proxy_e2e_anthropic_messages_tests | ||
| proxy_security_tests | ||
| proxy_unit_tests | ||
| router_unit_tests | ||
| scim_tests | ||
| search_tests | ||
| spend_tracking_tests | ||
| store_model_in_db_tests | ||
| test_litellm | ||
| unified_google_tests | ||
| vector_store_tests | ||
| windows_tests | ||
| __init__.py | ||
| eval_swe_bench.py | ||
| gettysburg.wav | ||
| large_text.py | ||
| openai_batch_completions.jsonl | ||
| README.MD | ||
| test_budget_management.py | ||
| test_callbacks_on_proxy.py | ||
| test_config.py | ||
| test_debug_warning.py | ||
| test_default_encoding_non_root.py | ||
| test_end_users.py | ||
| test_entrypoint.py | ||
| test_fallbacks.py | ||
| test_gpt5_azure_temperature_support.py | ||
| test_health.py | ||
| test_keys.py | ||
| test_litellm_proxy_responses_config.py | ||
| test_logging.conf | ||
| test_models.py | ||
| test_new_vector_store_endpoints.py | ||
| test_openai_endpoints.py | ||
| test_organizations.py | ||
| test_otel_thread_leak.py | ||
| test_passthrough_endpoints.py | ||
| test_presidio_latency.py | ||
| test_proxy_server_non_root.py | ||
| test_ratelimit.py | ||
| test_resource_cleanup.py | ||
| test_service_logger_otel.py | ||
| test_spend_logs.py | ||
| test_team_logging.py | ||
| test_team_members.py | ||
| test_team.py | ||
| test_users.py | ||
In total litellm runs 1000+ tests
[02/20/2025] Update:
To make it easier to contribute and map what behavior is tested,
we've started mapping the litellm directory in tests/test_litellm
This folder can only run mock tests.