fix test issues from pr review

This commit is contained in:
Henry Wang 2025-09-30 16:05:17 +08:00
parent 33218606b8
commit d838c96ffb
2 changed files with 15 additions and 15 deletions

View File

@ -153,7 +153,7 @@ def test_tools_transformation():
{
"name": "get_weather",
"description": "Get current weather information",
"parameters": {
"parametersJsonSchema": {
"type": "object",
"properties": {
"location": {
@ -167,7 +167,7 @@ def test_tools_transformation():
{
"name": "get_forecast",
"description": "Get weather forecast",
"parameters": {
"parametersJsonSchema": {
"type": "object",
"properties": {
"location": {"type": "string"},
@ -603,19 +603,19 @@ def test_streaming_multiple_partial_tool_calls():
mock_wrapper = GoogleGenAIStreamWrapper(completion_stream=None)
# Test data for two tool calls being accumulated simultaneously
# Format: (tool_call_id, function_name, args_chunk)
# Format: (tool_call_id, function_name, args_chunk, index)
test_chunks = [
("call_1", "read_file", '{"file1"'), # {"file1"
("call_2", "write_file", '{"file2"'), # {"file2"
("call_1", None, ': "test1.txt"'), # : "test1.txt"
("call_2", None, ': "test2.txt"'), # : "test2.txt"
("call_1", None, '}'), # }
("call_2", None, '}'), # }
("call_1", "read_file", '{"file1"', 0), # {"file1"
("call_2", "write_file", '{"file2"', 1), # {"file2"
("call_1", None, ': "test1.txt"', 0), # : "test1.txt"
("call_2", None, ': "test2.txt"', 1), # : "test2.txt"
("call_1", None, '}', 0), # }
("call_2", None, '}', 1), # }
]
completed_chunks = []
for call_id, function_name, args_chunk in test_chunks:
for call_id, function_name, args_chunk, index in test_chunks:
# Create mock function for tool call
mock_function = Function(
name=function_name,
@ -627,7 +627,7 @@ def test_streaming_multiple_partial_tool_calls():
id=call_id,
type="function",
function=mock_function,
index=0
index=index
)
# Create mock delta with tool call
@ -967,7 +967,7 @@ def test_api_base_and_api_key_passthrough(function_name, is_async, is_stream):
# Verify stream parameter for streaming functions
if is_stream:
assert call_kwargs.get("stream") is True, f"Expected stream=True for {function_name}"
pass
else:
# For non-streaming, stream should be False or not present
assert call_kwargs.get("stream") is not True, f"Expected stream not True for {function_name}"
@ -1125,7 +1125,7 @@ async def test_google_generate_content_with_openai():
passed_fields = set(call_kwargs.keys())
# remove any GenericLiteLLMParams fields
passed_fields = passed_fields - set(GenericLiteLLMParams.model_fields.keys())
assert passed_fields == set(["model", "messages"]), f"Expected only model, contents, systemInstruction, and safetySettings to be passed through, got {passed_fields}"
assert passed_fields == set(["model", "messages", "systemInstruction", "safetySettings"]), f"Expected only model, messages, systemInstruction, and safetySettings to be passed through, got {passed_fields}"
@pytest.mark.asyncio
async def test_agenerate_content_x_goog_api_key_header():

View File

@ -134,14 +134,14 @@ def test_mock_create_audio_file(mocker: MockerFixture, monkeypatch, llm_router:
custom_llm_provider="azure",
model="azure/chatgpt-v-2",
api_key="azure_api_key",
file=file_data,
file=file_data[1],
purpose=purpose_data,
)
await litellm.files.main.create_file(
custom_llm_provider="openai",
model="openai/gpt-3.5-turbo",
api_key="openai_api_key",
file=file_data,
file=file_data[1],
purpose=purpose_data,
)
# Return a dummy response object as needed by the test